Use the configured proxy host and port for the download #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohlendo Can you please fix the tests? |
The message field is again an object that contains a message. In order to receive the text, take that.
|
@nidhimj22 I have fixed the test. But the error wasn't related to my changes - should have been there before... |
|
@mohlendo Thanks! Can you also write a test case for this? You can mock the proxy. |
Testing download without and with a proxy
Use rimraf for recursive delete
The library version also runs with node v.0.10.x
|
Awesomeness! Thanks @mohlendo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly for https download over proxy, we need a special http agent implementation. Added a simple one, too.
Fixes #14